fix(starlette): fixes incorrect handling of path/root_path in older starlette versions #8613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root_path
now correctly contains the duplicated mounted path found inpath
forstarlette
> v0.34 as per ASGI standardsPreviously, there was no duplication when mounting applications on
starlette
. This required us to set tags using bothroot_path
andpath
. However, this was later fixed in later versions of starlette leading to duplication.Logic is now implemented such that the ASGI middleware follows the specifications and only takes the
path
into consideration for tracing and older versions ofstarlette
have their spans edited within thestarlette
integrationChanges are also made to the testing snapshots to account for the TestClient change after v0.20 in
starlette
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.@DataDog/security-design-and-guidance
.Reviewer Checklist