Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): native extensions are no longer optional on supported platforms #9169

Merged
merged 10 commits into from
Jun 20, 2024
7 changes: 2 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@

DEBUG_COMPILE = "DD_COMPILE_DEBUG" in os.environ

# stack_v2 profiling extensions are optional, unless they are made explicitly required by this environment variable
STACK_V2_REQUIRED = "DD_STACK_V2_REQUIRED" in os.environ

IS_PYSTON = hasattr(sys, "pyston_version_info")

LIBDDWAF_DOWNLOAD_DIR = HERE / "ddtrace" / "appsec" / "_ddwaf" / "libddwaf"
Expand Down Expand Up @@ -462,7 +459,7 @@ def get_exts_for(name):
"-DPY_MINOR_VERSION={}".format(sys.version_info.minor),
"-DPY_MICRO_VERSION={}".format(sys.version_info.micro),
],
optional=not STACK_V2_REQUIRED,
optional=False,
)
)

Expand All @@ -472,7 +469,7 @@ def get_exts_for(name):
CMakeExtension(
"ddtrace.internal.datadog.profiling.stack_v2._stack_v2",
source_dir=STACK_V2_DIR,
optional=not STACK_V2_REQUIRED,
optional=False,
),
)

Expand Down
Loading