Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: always skip sdist, use develop mode #928

Merged
merged 2 commits into from
May 10, 2019
Merged

tests: always skip sdist, use develop mode #928

merged 2 commits into from
May 10, 2019

Conversation

jd
Copy link
Contributor

@jd jd commented May 9, 2019

This should make installation faster and development easier.

@jd jd requested a review from a team as a code owner May 9, 2019 12:27
@jd jd added the dev/testing label May 9, 2019
@jd jd changed the base branch from 0.25-dev to master May 9, 2019 13:36
majorgreys
majorgreys previously approved these changes May 9, 2019
View reviewed changes
@jd
tests: always skip sdist, use develop mode
1a28574 
This should make installation faster and development easier.
@jd
Copy link
Contributor Author

jd commented May 10, 2019 •
edited
Loading

I missed we had a test_build target making sure we can build our source. So I think that's good enough and we can go ahead with that PR.

@jd jd merged commit 94e8df8 into DataDog:master May 10, 2019
@majorgreys majorgreys added this to the 0.26.0 milestone Jun 3, 2019
@majorgreys majorgreys mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majorgreys majorgreys majorgreys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jd @majorgreys