[pyramid] Fix dotted name for autopatched config test #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
changed the title
brettlangdon
approved these changes
May 9, 2019
jd
reviewed
May 10, 2019
| @@ -47,4 +47,4 @@ def test_config_include(): | |||
| """ This test makes sure that relative imports still work when the | |||
There was a problem hiding this comment.
I don't want to be a mood killer, but this test talks about relative import. I don't know why it exists, but I feel like this change break what the author wanted to test.
There was a problem hiding this comment.
Good point! I'll investigate this further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.