writer: log a message when a trace is dropped #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddtrace/writer.py
Outdated
| @@ -159,6 +159,7 @@ def put(self, item): | |||
| if qsize != 0: | |||
| idx = random.randrange(0, qsize) | |||
| self.queue[idx] = item | |||
| log.warn("Writer queue is full has more than %d traces, some traces will be lost", self.maxsize) | |||
There was a problem hiding this comment.
Suggested change
| log.warn("Writer queue is full has more than %d traces, some traces will be lost", self.maxsize) | |
| log.warn('Writer queue is full has more than %d traces, some traces will be lost', self.maxsize) |
brettlangdon
previously approved these changes
May 17, 2019
There's no way to know that the queue is getting full and that some traces are dropped. At least write a log message so the user knows something's wrong.
|
I think I'll never manage to get this quote thing right 😅 |
|
Ha, some day we'll move to |
brettlangdon
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no way to know that the queue is getting full and that some traces are
dropped. At least write a log message so the user knows something's wrong.