Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record HTTP status code correctly when using abort() with Bottle #943

Merged
merged 4 commits into from
May 20, 2019
Merged

Record HTTP status code correctly when using abort() with Bottle #943

merged 4 commits into from
May 20, 2019

Conversation

equake
Copy link
Contributor

@equake equake commented May 17, 2019

Datadog isn't recording the correct HTTP status code when using abort(status_code, 'message).

This PR fix this issue.

Thanks.

@equake equake requested a review from a team as a code owner May 17, 2019 17:55
@brettlangdon brettlangdon added this to the 0.26.0 milestone May 17, 2019
@brettlangdon
Copy link
Member

@equake thanks for this contribution!

Looks like flake8 is failing on an unused variable in bottle/test.py, but other than that, looks good to me!

@equake
Copy link
Contributor Author

equake commented May 17, 2019

Fixed!

@majorgreys majorgreys merged commit c6bd5ff into DataDog:master May 20, 2019
@equake
Copy link
Contributor Author

equake commented May 22, 2019

Thanks 👍

@equake equake deleted the fix-bottlepy-abort branch May 23, 2019 18:21
@majorgreys majorgreys mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@equake @brettlangdon @jd @majorgreys