api: simplify _put codepath #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The length is always provided and should be included in every request, so make it mandatory. Move the header name variable to the local API class, making it overridable by a subclass — you never know!
brettlangdon
approved these changes
May 31, 2019
| @@ -169,14 +171,12 @@ def send_traces(self, traces): | |||
| def send_services(self, *args, **kwargs): | |||
| return | |||
|
|
|||
| def _put(self, endpoint, data, count=0): | |||
There was a problem hiding this comment.
Context, count used to be optional since we used to use the same endpoint for sending services, which did not include the trace count header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length is always provided and should be included in every request, so make
it mandatory.
Move the header name variable to the local API class, making it overridable by
a subclass — you never know!