Run flake8 with Python 3 #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to remove a few noqa flag from files using `yield from` and fixing various errors. The compat tests have been merged to a single scenario that works for both Python version in order to make flake8 happier. Some wild noqa tag have been replaced by specific flake8 error code ignore tag so avoid skipping non-wanted mistakes.
brettlangdon
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to remove a few noqa flag from files using
yield fromand fixingvarious errors.
The compat tests have been merged to a single scenario that works for both
Python version in order to make flake8 happier.
Some wild noqa tag have been replaced by specific flake8 error code ignore tag
so avoid skipping non-wanted mistakes.