Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tornado): run the tornado suite when the futures contrib changes #9656

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 26, 2024

This change updates the suitespec to run the tornado and tracer suites on pull requests that change contrib/futures. This is necessary because #9588 introduced failures (1 2) in those suites that were only discovered post-merge.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 26, 2024
@emmettbutler emmettbutler requested a review from a team as a code owner June 26, 2024 18:33
@emmettbutler emmettbutler enabled auto-merge (squash) June 26, 2024 18:38
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 26, 2024

Datadog Report

Branch report: emmett.butler/tornado-futures-spec
Commit report: 9e4b71d
Test service: dd-trace-py

✅ 0 Failed, 117518 Passed, 59140 Skipped, 4h 10m 21.27s Total duration (5h 39m 37.12s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.12%. Comparing base (deadfcd) to head (9e4b71d).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9656       +/-   ##
===========================================
- Coverage   75.61%   10.12%   -65.50%     
===========================================
  Files        1336     1348       +12     
  Lines      125991   125900       -91     
===========================================
- Hits        95271    12748    -82523     
- Misses      30720   113152    +82432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmettbutler emmettbutler merged commit c9a16ed into main Jun 26, 2024
147 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/tornado-futures-spec branch June 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants