writer: tag as private, merge worker #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also add in a from .internal.writer import Writer
__all__ = ['Writer']if we needed to keep some import/API compatibility. |
|
I actually don't want people to keep using it (if they ever did) since I'm removing a kwarg. :) Yeah I can move to |
jd
changed the title
jd
force-pushed
the
remove-service-queue
branch
from
406ea6e to
648a4e4
Compare
There's no reason to have this two distinct since they are never used without each other anyway. This simplifies the architecture a little bit and makes things easier to grasp.
jd
force-pushed
the
remove-service-queue
branch
from
a6f7572 to
217a8c6
Compare
brettlangdon
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.