fix(profiling): better autoinject detection

[sanchda]

PROF-10280

Previously, Profiling was injecting its own configuration during lib-injection handling. This was actually a little brittle.

Instead, we move to a model where the profiler detects (in its normal configuration) whether the library was injected. Hopefully this is more durable and correct.

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[sanchda]

• fix(profiling): better autoinject detection #9904 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sanchda and the rest of your teammates on Graphite

[github-actions]

CODEOWNERS have been resolved as:

releasenotes/notes/profiling-fix-autoinject-detection-fa5035fb0c4719cc.yaml  @DataDog/apm-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/Dockerfile     @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/Readme.md      @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/addressbook_pb2.py  @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/requirements.txt  @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/test.py        @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-protobuf-old/validate_telemetry.py  @DataDog/apm-core-python
.github/workflows/lib-inject-prune.yml                                  @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
ddtrace/settings/profiling.py                                           @DataDog/profiling-python
lib-injection/sitecustomize.py                                          @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-django-unsupported-package-force/Dockerfile  @DataDog/apm-core-python
tests/lib-injection/dd-lib-python-init-test-django/Dockerfile           @DataDog/apm-core-python

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: 07-23-fix_profiling_better_autoinject_detection
Commit report: d896677
Test service: dd-trace-py

✅ 0 Failed, 122120 Passed, 56300 Skipped, 3h 55m 46.05s Total duration (5h 20m 19.43s time saved)

[Kyle-Verhoog]

just one thought, otherwise good to me!

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-08-07 13:32:43

Comparing candidate commit 920c8e7 in PR branch 07-23-fix_profiling_better_autoinject_detection with baseline commit ab8588c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 10.55%. Comparing base (120ba6d) to head (d3934f4).
Report is 4 commits behind head on main.

Files	Patch %	Lines
ddtrace/settings/profiling.py	0.00%	19 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9904       +/-   ##
===========================================
- Coverage   73.57%   10.55%   -63.03%     
===========================================
  Files        1421     1381       -40     
  Lines      131945   129203     -2742     
===========================================
- Hits        97078    13635    -83443     
- Misses      34867   115568    +80701     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport-9904-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d638a7b92d1ef01b78fad6cb1d44c27543c47059
# Push it to GitHub
git push --set-upstream origin backport-9904-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport-9904-to-2.9.

[github-actions]

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport-9904-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d638a7b92d1ef01b78fad6cb1d44c27543c47059
# Push it to GitHub
git push --set-upstream origin backport-9904-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport-9904-to-2.10.