Skip to content

Commit

Permalink
Document that trace_identifiers_for gets called while holding the GVL
Browse files Browse the repository at this point in the history
  • Loading branch information
ivoanjo committed Nov 1, 2022
1 parent bb95c1c commit c7f6401
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,7 @@ static VALUE _native_stats(DDTRACE_UNUSED VALUE _self, VALUE collector_instance)
return stats_as_ruby_hash(state);
}

// Assumption 1: This function is called in a thread that is holding the Global VM Lock. Caller is responsible for enforcing this.
static void trace_identifiers_for(struct cpu_and_wall_time_collector_state *state, VALUE thread, struct trace_identifiers *trace_identifiers_result) {
if (state->tracer_context_key == MISSING_TRACER_CONTEXT_KEY) return;

Expand Down

0 comments on commit c7f6401

Please sign in to comment.