Skip to content

Commit

Permalink
Fix outdated comment
Browse files Browse the repository at this point in the history
It's no longer true that we don't use the new Ruby profiler on Ruby 2.5;
what's true is that we enable the "no signals workaround" to avoid the
potentially-problematic code path.
  • Loading branch information
ivoanjo committed Dec 2, 2024
1 parent d30cb18 commit ea1a525
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ bool is_current_thread_holding_the_gvl(void) {
//
// Thus an incorrect `is_current_thread_holding_the_gvl` result may lead to issues inside `rb_postponed_job_register_one`.
//
// For this reason we currently do not enable the new Ruby profiler on Ruby 2.5 by default, and we print a
// For this reason we default to use the "no signals workaround" on Ruby 2.5 by default, and we print a
// warning when customers force-enable it.
bool gvl_acquired = vm->gvl.acquired != 0;
rb_thread_t *current_owner = vm->running_thread;
Expand Down

0 comments on commit ea1a525

Please sign in to comment.