Merge pull request #3877 from DataDog/tonycthsu/backport-disable-pers…

…ist-credentials Backport disable persist credentials
DataDog · Sep 2, 2024 · edd7a25 · edd7a25
2 parents 8b88cdd + abc8342
commit edd7a25
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/lib-injection.yml b/.github/workflows/lib-injection.yml
@@ -50,20 +50,21 @@ jobs:
     env:
       TEST_LIBRARY: ruby
       WEBLOG_VARIANT: ${{ matrix.weblog-variant }}
-      DOCKER_REGISTRY_IMAGES_PATH: ghcr.io/datadog
-      DOCKER_IMAGE_TAG: ${{ github.sha }}
+      LIB_INIT_IMAGE: ghcr.io/datadog/dd-trace-rb/dd-lib-ruby-init:${{ github.sha }}
+      LIBRARY_INJECTION_TEST_APP_IMAGE: ghcr.io/datadog/system-tests/${{ matrix.weblog-variant }}:latest
       BUILDX_PLATFORMS: linux/amd64,linux/arm64/v8
     steps:
     - name: Checkout system tests
       uses: actions/checkout@v4
       with:
           repository: 'DataDog/system-tests'
+          persist-credentials: false
 
     - name: Install runner
-      uses: ./.github/actions/install_runner 
+      uses: ./.github/actions/install_runner
 
     - name: Run K8s Lib Injection Tests
-      run: ./run.sh K8S_LIB_INJECTION_BASIC
+      run: ./run.sh K8S_LIBRARY_INJECTION_BASIC
 
     - name: Compress logs
       id: compress_logs
@@ -91,6 +92,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: DataDog/system-tests
+          persist-credentials: false
           path: system-tests
       - name: Overwrite auto inject script with commit SHA
         run: |

diff --git a/.github/workflows/system-tests.yml b/.github/workflows/system-tests.yml
@@ -31,6 +31,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: 'DataDog/system-tests'
+          persist-credentials: false
       - name: Pull released image
         run: |
           if docker pull ${{ env.REPO }}/system-tests/${{ matrix.image.name }}:latest; then
@@ -104,6 +105,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: 'DataDog/system-tests'
+          persist-credentials: false
       - name: Checkout ${{ matrix.library.repository }}
         uses: actions/checkout@v4
         with:
@@ -250,6 +252,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: 'DataDog/system-tests'
+          persist-credentials: false
       - name: Pull runner image
         run: |
           docker pull ${{ env.REPO }}/system-tests/runner:gha${{ github.run_id }}-g${{ github.sha }}
@@ -316,6 +319,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           repository: 'DataDog/system-tests'
+          persist-credentials: false
       - name: Retrieve logs
         uses: actions/download-artifact@v4
         with: