Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faraday trace headers #210

Closed
walterking opened this issue Oct 2, 2017 · 1 comment
Closed

faraday trace headers #210

walterking opened this issue Oct 2, 2017 · 1 comment
Assignees
Labels
bug Involves a bug integrations Involves tracing integrations
Milestone

Comments

@walterking
Copy link
Contributor

I dont use faraday, but shouldn't
https://github.com/DataDog/dd-trace-rb/blob/master/lib/ddtrace/contrib/faraday/middleware.rb#L59
be
Ext::DistributedTracing::HTTP_HEADER_PARENT_ID => span.span_id
like http/patcher.rb?

@palazzem palazzem added this to the 0.9.0 milestone Oct 2, 2017
@palazzem palazzem added bug Involves a bug integrations Involves tracing integrations labels Oct 2, 2017
@palazzem palazzem self-assigned this Oct 2, 2017
@palazzem
Copy link
Contributor

palazzem commented Oct 2, 2017

@walterking good catch! Yes the header is called *_parent_id but of course it should be related to the current span.span_id (since that one will be the parent of the other service root span).

Making a PR immediately! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

2 participants