[faraday] update the HTTP_HEADER_PARENT_ID to send the span_id instead of parent_id #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
added
enhancement
integrations
p-lambert
requested changes
Oct 2, 2017
There was a problem hiding this comment.
Ouch. Sorry about that!
Can we also update this test?
https://github.com/DataDog/dd-trace-rb/blob/master/test/contrib/faraday/middleware_test.rb#L96
palazzem
force-pushed
the
palazzem/faraday-headers
branch
from
cb24e6f to
0156962
Compare
palazzem
commented
Oct 2, 2017
| @@ -93,7 +93,7 @@ def test_distributed_tracing | |||
| span = request_span | |||
|
|
|||
| assert_equal(headers[Ext::DistributedTracing::HTTP_HEADER_TRACE_ID], span.trace_id) | |||
| assert_equal(headers[Ext::DistributedTracing::HTTP_HEADER_PARENT_ID], span.parent_id) | |||
| assert_equal(headers[Ext::DistributedTracing::HTTP_HEADER_PARENT_ID], span.span_id) | |||
palazzem
force-pushed
the
palazzem/faraday-headers
branch
from
778f34a to
82ac4ca
Compare
p-lambert
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The current version sends the wrong value via headers when doing distributed tracing (
span.parent_idinstead of thespan.span_id).Closes #210
What is missing
to_sbecause we need to make a real call