Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen constraint on debase-ruby_core_source version #4058

Closed
mscrivo opened this issue Nov 1, 2024 · 2 comments
Closed

Loosen constraint on debase-ruby_core_source version #4058

mscrivo opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one

Comments

@mscrivo
Copy link
Contributor

mscrivo commented Nov 1, 2024

We're trying to upgrade to debase 0.26, which finally fixes the compilation issues on recent versions macOS/xcode, but we've run into this issue:

Could not find compatible versions

Because debase >= 0.2.6, < 3.0.0.beta.12 depends on debase-ruby_core_source >= 3.3.6
  and every version of datadog depends on debase-ruby_core_source = 3.3.1,
  debase >= 0.2.6, < 3.0.0.beta.12 is incompatible with datadog >= 0.
So, because Gemfile depends on datadog >= 0
  and Gemfile depends on debase ~> 0.2.6,
  version solving has failed.

Would it be possible to loosen the constraint on debase-ruby_core_source?

@mscrivo mscrivo added community Was opened by a community member feature-request A request for a new feature or change to an existing one labels Nov 1, 2024
@ivoanjo ivoanjo self-assigned this Nov 4, 2024
@ivoanjo
Copy link
Member

ivoanjo commented Nov 4, 2024

Hey @mscrivo thanks for reaching out as usual and sorry for the sharp edge 👀

TL;DR for the next dd-trace-rb version we're actually replacing the debase-ruby_core_source dependency with our own fork (see #4014 ). So you should be good to go with 2.5.0 once it's out.

(Non TL;DR version is: We wanted to trim some of the unused headers + be able to do a few tweaks that we don't think make sense to submit upstream as debase has different needs)

@mscrivo
Copy link
Contributor Author

mscrivo commented Nov 4, 2024

Thanks!

@mscrivo mscrivo closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Projects
None yet
Development

No branches or pull requests

2 participants