Replace 'debase' with 'datadog'-ruby_core_source #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahchen6
force-pushed
the
sarahchen6/update-ruby-core-soure-gem
branch
3 times, most recently
from
985ce62 to
8da89c9
Compare
ivoanjo
reviewed
Oct 21, 2024
BenchmarksBenchmark execution time: 2024-10-22 14:00:55 Comparing candidate commit 9743f03 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 2 unstable metrics. |
sarahchen6
force-pushed
the
sarahchen6/update-ruby-core-soure-gem
branch
from
fc7dd3c to
379eb47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4014 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1319 1319
Lines 79141 79141
Branches 3927 3927
=======================================
Hits 77449 77449
Misses 1692 1692 ☔ View full report in Codecov by Sentry. |
ivoanjo
approved these changes
Oct 22, 2024
TonyCTHsu
force-pushed
the
sarahchen6/update-ruby-core-soure-gem
branch
from
80d83be to
ccc12f4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log entry
Replace the
debase-ruby_core_sourcegem with thedatadog-ruby_core_source.What does this PR do?
This PR replaces the
debase-ruby_core_sourcegem with thedatadog-ruby_core_sourcegem.Motivation:
The goal of this PR is to update the library such that it now uses the
datadog-ruby_core_sourceRuby gem.Additional Notes:
This PR is a step toward the overall project goal of creating a new
datadog-ruby_core_sourcegem. See here for more info on the project.How to test the change?
TBD
Unsure? Have a question? Request a review!