[env] using Rails environment only when asked to do so #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
palazzem
reviewed
Apr 7, 2017
docs/GettingStarted.md
Outdated
| @@ -65,7 +65,8 @@ of the Datadog tracer, you can override the following defaults: | |||
| debug: false, | |||
| trace_agent_hostname: 'localhost', | |||
| trace_agent_port: 8126, | |||
| env: Rails.env, | |||
| use_rails_env: false, | |||
There was a problem hiding this comment.
what I'm worried about, is that we're polluting a lot Rails settings to provide "almost any kind of behavior" with flags rather than be explicit (i.e.: if you want to use the Rails env, just set env: Rails.env)
docs/GettingStarted.md
Outdated
| @@ -88,7 +89,8 @@ Available settings are: | |||
| * ``debug``: set to true to enable debug logging. | |||
| * ``trace_agent_hostname``: set the hostname of the trace agent. | |||
| * ``trace_agent_port``: set the port the trace agent is listening on. | |||
| * ``env``: set the environment. Defaults to the Rails environment | |||
| * ``use_rails_env``: guess the Datadog environment from the Rails environment. | |||
| * ``env``: set the environment. Overridden by Rails environment if ``use_rails_env`` is set. | |||
There was a problem hiding this comment.
Not totally sure that is good to have two different settings to provide (and override) the same thing. If using the Rails.env could create issues, I'll probably go with a default env: nil and let the user to be explicit.
palazzem
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the side effects described in #92