[core] Span class can be finished only once #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
reviewed
Apr 13, 2017
lib/ddtrace/span.rb
Outdated
| @@ -91,6 +92,9 @@ def set_error(e) | |||
|
|
|||
| # Mark the span finished at the current time and submit it. | |||
| def finish | |||
| return if @finished | |||
| @finished = true | |||
|
|
|||
There was a problem hiding this comment.
Generally speaking, I'm all in for this, finish should be done only once. Then I'm a little worried about what it means to call finish_at. Because, here, finish_at can still be called many times, so its name becomes quite misleading. I don't know if it makes sense to move this test to finish_at so that this function too, can not be call twice. And the other question is, do we need the boolean or would !@end_time.nil? be enough to consider is "finishable".
palazzem
force-pushed
the
palazzem/double-finish
branch
from
1c0279f to
7a74efa
Compare
palazzem
force-pushed
the
palazzem/double-finish
branch
from
7a74efa to
2fc9cfc
Compare
ufoot
approved these changes
Apr 13, 2017
| self | ||
| end | ||
|
|
||
| # Proxy function that flag a span as finished with the given | ||
| # timestamp. This function is used for retro-compatibility. | ||
| # DEPRECATED: remove this function in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Calling
span.finish()multiple times doesn't have any effect.