Remove circular dependencies. #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
requested changes
Sep 6, 2021
There was a problem hiding this comment.
Hey Jim!
Thanks for the contribution, the circular dependencies warning can be quite annoying when one is trying to run a tight warning-free shop ;)
I've left a few notes regarding some require 'ddtrace's that are actually intended, as we have some use-cases where they do get used as entry points to the library, if you could remove them, we'll be very thankful for the contribution :)
saturnflyer
force-pushed
the
circular-dependencies
branch
from
bb0e795
to
64c97fe
Compare
|
thanks for the feedback @ivoanjo |
ivoanjo
approved these changes
Sep 8, 2021
marcotc
added
community
|
@saturnflyer, thank you again for your contribution. 0.53.0 was just released, including the changes in this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring ddtrace leads to requiring these files which in turn require ddtrace