Add sucker_punch integration
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-lambert
force-pushed
the
pedro/add-suckerpunch-integration
branch
3 times, most recently
from
98915e3 to
5c8cad1
Compare
p-lambert
force-pushed
the
pedro/add-suckerpunch-integration
branch
3 times, most recently
from
43404e3 to
d238432
Compare
p-lambert
force-pushed
the
pedro/add-suckerpunch-integration
branch
from
d238432 to
8ee8e81
Compare
palazzem
reviewed
Sep 25, 2017
| pin.tracer.provider.context = Datadog::Context.new | ||
|
|
||
| __with_instrumentation do |span| | ||
| span.resource = "#{self} [process]" |
There was a problem hiding this comment.
We may change that one as PROCESS LogJob
| def __with_instrumentation | ||
| pin = Datadog::Pin.get_from(::SuckerPunch) | ||
|
|
||
| ::SuckerPunch.datadog_pin.tracer.trace(pin.service) do |span| |
There was a problem hiding this comment.
it would be great having something like:
sucker_punch.perform_asyncsucker_punch.run_performsucker_punch.perform_in
| assert_equal('sucker_punch', span.name) | ||
| assert_equal('DummyWorker [process]', span.resource) | ||
| assert_equal('DummyWorker', span.get_tag('sucker_punch.queue')) | ||
| assert_equal(Ext::Errors::STATUS, span.status) |
There was a problem hiding this comment.
we may check the message and the exception class here
p-lambert
force-pushed
the
pedro/add-suckerpunch-integration
branch
from
8ee8e81 to
8e69ec4
Compare
p-lambert
force-pushed
the
pedro/add-suckerpunch-integration
branch
from
8e69ec4 to
c705bed
Compare
palazzem
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The sucker_punch integration traces all scheduled jobs: