[PROF-6463] Implement support for endpoint profiling in CpuAndWallTime collector #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby doesn't mind that we call `instance_variable_get` on `nil`, but it will emit warnings, which can be annoying. To avoid this, let's properly check that things are `nil` before using them.
…e collector **What does this PR do?**: This PR reimplements support for the profiling endpoint feature in the `CpuAndWallTime` collector. Although the implementation is different, the approach is conceptually the same as provided by `Datadog::Profiling::TraceIdentifiers::Ddtrace` for the old profiler codepaths. The constraints of this implementation are the same as the ones in #2342 and effectively this is only a small extension of the work done in that PR. **Motivation**: Endpoint profiling allows customers to filter down their profiles to individual endpoints (for web apps) that they may be interested in investigating. **Additional Notes**: Comparing a Ruby string with a `char *` is really annoying. **How to test the change?**: Beyond the code coverage included by the change, it can also be tested by enabling profiling and tracing for a Ruby web app, and then checking that the application's endpoints show up in the right sidebar in the profiling UX.
marcotc
reviewed
Nov 22, 2022
| // | ||
| // Instead of each sample for the same local_root_span_id getting a potentially-different endpoint, | ||
| // `record_endpoint` (via libdatadog) keeps a list of local_root_span_id values and their most-recently-seen | ||
| // endpoint values, and at serialization time the most-recently-seen endpoint is applied to all relevant samples. |
There was a problem hiding this comment.
most-recently-seen endpoint is applied to all relevant samples
This is a very reasonable approach! 👍 👍 👍
marcotc
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR reimplements support for the profiling endpoint feature in the
CpuAndWallTimecollector.Although the implementation is different, the approach is conceptually the same as provided by
Datadog::Profiling::TraceIdentifiers::Ddtracefor the old profiler codepaths.The constraints of this implementation are the same as the ones in #2342 and effectively this is only a small extension of the work done in that PR.
Motivation:
Endpoint profiling allows customers to filter down their profiles to individual endpoints (for web apps) that they may be interested in investigating.
Additional Notes:
Comparing a Ruby string with a
char *is really annoying.How to test the change?:
Beyond the code coverage included by the change, it can also be tested by enabling profiling and tracing for a Ruby web app, and then checking that the application's endpoints show up in the right sidebar in the profiling UX.