Temporarily disable GC profiling by default in new Ruby profiler due to overhead #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to overhead **What does this PR do?**: We previously only enabled GC profiling by default on Ruby 2.x (we disabled it on 3.x due to a bug, see #2354). This PR changes the profiling configuration to never enable GC profiling by default (thus bringing the Ruby 2.x and 3.x defaults into sync). **Motivation**: I've had one new Ruby profiler alpha user report that GC profiling had a quite big overhead, and I could replicate the issue on a GC-heavy benchmark. Since we'd like to get the new Ruby profiler out into customer's hands in beta, I decided to disable this feature by default, and come back to it after beta is out. **Additional Notes**: GC profiling can still be enabled via configuration. **How to test the change?**: Change includes test coverage. Furthermore, profiling any application will no longer show the `Garbage Collection` frames in the flamegraph by default.
ivoanjo
added
profiling
Codecov Report
@@ Coverage Diff @@
## master #2481 +/- ##
=======================================
Coverage 98.31% 98.32%
=======================================
Files 1118 1118
Lines 60341 60337 -4
=======================================
- Hits 59327 59324 -3
+ Misses 1014 1013 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
We previously only enabled GC profiling by default on Ruby 2.x (we disabled it on 3.x due to a bug, see #2354).
This PR changes the profiling configuration to never enable GC profiling by default (thus bringing the Ruby 2.x and 3.x defaults into sync).
Motivation:
I've had one new Ruby profiler alpha user report that GC profiling had a quite big overhead, and I could replicate the issue on a GC-heavy benchmark.
Since we'd like to get the new Ruby profiler out into customer's hands in beta, I decided to disable this feature by default, and come back to it after beta is out.
Additional Notes:
GC profiling can still be enabled via configuration.
How to test the change?:
Change includes test coverage. Furthermore, profiling any application will no longer show the
Garbage Collectionframes in the flamegraph by default.