Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Ruby 3.2.0 final #2510

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Move to Ruby 3.2.0 final #2510

merged 1 commit into from
Jan 3, 2023

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Dec 28, 2022

What does this PR do?

Move from the preview ruby image to the final one.

Motivation

So we can base ourselves on the latest thing to make things pass.

Additional Notes

CircleCI test is still disabled as tests don't pass yet, so we can change that right away as well without caring about the image being published.

How to test the change?

This should build the image in CI. As always publishing is done later.

Image can also be built locally as always, and then tested using docker compose:

docker buildx build . --platform linux/$(uname -m | sed 's/arm64/aarch64/') -f Dockerfile-3.1.1 -t ghcr.io/datadog/dd-trace-rb/ruby:3.1.1-dd
docker-compose run --rm tracer-3.2 /bin/bash

@lloeki lloeki requested a review from a team December 28, 2022 14:35
@marcotc
Copy link
Member

marcotc commented Dec 28, 2022

Similar to https://github.com/DataDog/dd-trace-rb/pull/2497/files.

I found an issue with Appraisal not being compatible with Ruby 3.2, which is kind of a deal breaker :(

@lloeki
Copy link
Member Author

lloeki commented Dec 29, 2022

Yeah @marcotc, although this PR is merely about bumping the version from 3.2.0-preview3 to 3.2.0 throughout, not about actually fixing and enabling 3.2 (which IIUC is the goal of #2497)

@marcotc marcotc merged commit e33aae0 into master Jan 3, 2023
@marcotc marcotc deleted the move-to-3.2.0-final branch January 3, 2023 21:54
@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Jan 3, 2023
@github-actions github-actions bot added this to the 1.9.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants