Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade profiler to use libdatadog v2.0.0 #2599

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Upgrade profiler to use libdatadog v2.0.0 #2599

merged 5 commits into from
Feb 9, 2023

Commits on Feb 3, 2023

  1. Attach local root span id to profiling samples as a number not as a s… 

    …tring

This is a newly-added feature to both the profiling backend, as well as
libdatadog.

Instead of sending the local root span ids as strings (that take up
space in the string table, etc), we can now send them as numbers.

We already did a similar migration for span ids in #2476, but at
the time we did not change the local root span ids because the
libdatadog `ddog_prof_Profile_set_endpoint` API could not properly
handle the numeric ids (this has been changed in
DataDog/libdatadog#80 ).

As far as testing goes, I could have chosen to abstract away this
change from our specs BUT I chose to make it explicit and changed the
specs to match. I like having visibility in the specs of the values
being encoded and passed around as numbers and not strings.
    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    00b9546 View commit details
    Browse the repository at this point in the history

  2. Raise ArgumentError when ddog_prof_Profile_add returns a failure 

    This will allow us to have early warning for when we're using the
API incorrectly.

See also DataDog/libdatadog#87 .
    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    0a7f10a View commit details
    Browse the repository at this point in the history

  3. Adopt to new error reporting API, as well as to new drop methods 

    One of the drop methods had to be commented out due to a libdatadog bug,
I'll re-enable it once libdatadog gets fixed.
    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9a42eaf View commit details
    Browse the repository at this point in the history

  4. Remove FIXME now that libdatadog has been fixed

    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    2a52553 View commit details
    Browse the repository at this point in the history

  5. Bump dependency to pull in libdatadog 2.0

    @ivoanjo
    ivoanjo committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f4abd1d View commit details
    Browse the repository at this point in the history