Fix 'uninitialized constant GRPC::Interceptor' when with the 'gapic-common' gem #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error
when gRPC was partially loaded.
This has been reported to us by users of the Google Calendar User Availability API gem. That gem is not publicly available yet, but its dependency on the public
gapic-commongem is where the issue lies, allowing us to address this issue.gapic-commononly loads a couple file from gPRC, which only contain constants and error classes.There's nothing of value to instrument if only such subset of gPRC is loaded.
This PR ensures we check for the presence of the relevant gPRC client and server files that we actually have an instrumentation point.