-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Component dependency manager #2849
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
Application Security monitoring product
ci-app
CI product for test suite instrumentation
core
Involves Datadog core libraries
profiling
Involves Datadog profiling
tracing
labels
May 15, 2023
marcotc
changed the title
Component dependency manager
[WIP] Component dependency manager
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[The PR has not undergone any clean up. Naming of classes/modules are all up for change. File organization will be changed as well]
As part of the remote configuration effort, this PR changes the underlying component lifecycle management to use dependency injection.
This provides the following features:
Sampling.sampling_rate=
, instead of the defaultSampling.new(sampling_rate)
). This can reduce even further the overhead of reconfiguration.ddtrace
.Datadog.configuration
to retrieve settings is removed from components, and instead configuration is provided at initialization time.