Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove puts from test file #2914

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Remove puts from test file #2914

merged 2 commits into from
Jun 22, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jun 19, 2023

We forgot a puts in one of our tests files.

@marcotc marcotc requested a review from a team June 19, 2023 20:27
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Jun 19, 2023
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@@ -930,7 +930,6 @@
sleep(duration_wall_time)
span_op.stop

puts "\nduration: #{duration}\nwall_time: #{duration_wall_time * 1e9}\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell, trusted puts, and may you look kindly down on dd-trace-rb from your place in Ruby heaven.

@ivoanjo ivoanjo merged commit 0e396e9 into master Jun 22, 2023
@ivoanjo ivoanjo deleted the remove-puts branch June 22, 2023 08:15
@github-actions github-actions bot added this to the 1.13.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants