Actions:Allow type check to run at PR level #2929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All external PRs are stuck because "Check types" does run for external contributors, not even after manual approval (see #2928, for example):
Interestingly CodeQL does work correctly, running on approval:
My research was not 100% conclusive, but I believe that the
on
trigger is the reason.This PR change the
on
trigger to look more similar to CodeQL's, specifically regarding having an explicitpull_request
trigger.