Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions:Allow type check to run at PR level #2929

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jun 23, 2023

All external PRs are stuck because "Check types" does run for external contributors, not even after manual approval (see #2928, for example):
Screenshot 2023-06-23 at 2 09 41 PM

Interestingly CodeQL does work correctly, running on approval:
Screenshot 2023-06-23 at 2 10 37 PM

My research was not 100% conclusive, but I believe that the on trigger is the reason.

This PR change the on trigger to look more similar to CodeQL's, specifically regarding having an explicit pull_request trigger.

@marcotc marcotc requested a review from a team June 23, 2023 21:12
@marcotc marcotc self-assigned this Jun 23, 2023
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Jun 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2929 (590789f) into master (b5eee29) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   97.96%   97.96%   -0.01%     
==========================================
  Files        1282     1282              
  Lines       70682    70681       -1     
  Branches     3249     3249              
==========================================
- Hits        69241    69240       -1     
  Misses       1441     1441              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Thanks for improving the experience for contributors :)

LGTM 👍

@marcotc marcotc merged commit ad2e282 into master Jun 27, 2023
@marcotc marcotc deleted the type-check-trigger branch June 27, 2023 21:06
@github-actions github-actions bot added this to the 1.13.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants