Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG to mention YJIT stat tracking #2959

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

HeyNonster
Copy link
Contributor

In #2711, I forgot to include an update to the CHANGELOG.

What does this PR do?
Only updates the CHANGELOG.

Motivation
Wanting to mention the YJIT stat tracking so that folks interested in tracking them don't miss it.

Additional Notes
n/a

How to test the change?
n/a documentation only

In #2711, I forgot to include an update to the CHANGELOG.
@HeyNonster HeyNonster requested a review from a team July 12, 2023 09:28
@github-actions github-actions bot added docs Involves documentation release Official release labels Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2959 (c91f297) into master (4890f92) will increase coverage by 0.10%.
The diff coverage is 99.04%.

@@            Coverage Diff             @@
##           master    #2959      +/-   ##
==========================================
+ Coverage   97.96%   98.07%   +0.10%     
==========================================
  Files        1287     1301      +14     
  Lines       71025    71825     +800     
  Branches     3285     3307      +22     
==========================================
+ Hits        69581    70442     +861     
+ Misses       1444     1383      -61     
Impacted Files Coverage Δ
lib/datadog/appsec/contrib/devise/patcher.rb 69.56% <ø> (-2.44%) ⬇️
lib/datadog/tracing/contrib/opensearch/quantize.rb 94.44% <94.44%> (ø)
lib/datadog/tracing/contrib/opensearch/patcher.rb 96.92% <96.92%> (ø)
...datadog/tracing/contrib/opensearch/patcher_spec.rb 99.23% <99.23%> (ø)
lib/datadog/appsec/contrib/devise/event.rb 100.00% <100.00%> (ø)
...ec/contrib/devise/patcher/authenticatable_patch.rb 100.00% <100.00%> (+75.67%) ⬆️
...ib/devise/patcher/registration_controller_patch.rb 100.00% <100.00%> (+68.96%) ⬆️
lib/datadog/kit/appsec/events.rb 100.00% <100.00%> (ø)
lib/datadog/profiling/component.rb 97.67% <100.00%> (+0.11%) ⬆️
lib/datadog/profiling/load_native_extension.rb 100.00% <100.00%> (ø)
... and 11 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcotc
Copy link
Member

marcotc commented Jul 13, 2023

👋, @HeyNonster, we normally build the changelog from GitHub pull request titles and descriptions when we are preparing a new release.

It's totally ok to have it added now (and helpful); I just wanted to let you know that this entry wasn't technically missing from the original PR (our regular process doesn't require it at PR time.)

@HeyNonster
Copy link
Contributor Author

👋, @HeyNonster, we normally build the changelog from GitHub pull request titles and descriptions when we are preparing a new release.

It's totally ok to have it added now (and helpful); I just wanted to let you know that this entry wasn't technically missing from the original PR (our regular process doesn't require it at PR time.)

Awesome, thanks @marcotc :)

@delner
Copy link
Contributor

delner commented Jul 21, 2023

@marcotc What's the resolution on this one? Should we merge or close this?

@marcotc marcotc merged commit 496a534 into DataDog:master Jul 21, 2023
@marcotc
Copy link
Member

marcotc commented Jul 21, 2023

Merge it! 👍

@github-actions github-actions bot added this to the 1.13.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation release Official release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants