Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal:Fix environment variable for remote configuration polling interval #2967

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Internal:Fix environment variable for remote configuration polling interval #2967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
490d98b
Internal:Fix environment variable for remote configuration polling in…
marcotc Jul 13, 2023
fe971f4
Improve private language
marcotc Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/datadog/core/configuration/settings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,9 +540,11 @@ def initialize(*_)
end

# Tune remote configuration polling interval.
# This is a private setting. Do not use outside of Datadog. It might change at any point in time.
#
# @default `DD_REMOTE_CONFIGURATION_POLL_INTERVAL_SECONDS` environment variable, otherwise `5.0` seconds.
# @default `DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS` environment variable, otherwise `5.0` seconds.
# @return [Float]
# @!visibility private
option :poll_interval_seconds do |o|
o.default { env_to_float(Core::Remote::Ext::ENV_POLL_INTERVAL_SECONDS, 5.0) }
end
Expand Down
2 changes: 1 addition & 1 deletion lib/datadog/core/remote/ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Core
module Remote
module Ext
ENV_ENABLED = 'DD_REMOTE_CONFIGURATION_ENABLED'
ENV_POLL_INTERVAL_SECONDS = 'DD_REMOTE_CONFIGURATION_POLL_INTERVAL_SECONDS'
ENV_POLL_INTERVAL_SECONDS = 'DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS'
Comment on lines 7 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes this setting somewhat inconsistent with DD_REMOTE_CONFIGURATION_ENABLED. I've searched on github and it seems internally we have both DD_REMOTE_CONFIGURATION_ENABLED and DD_REMOTE_CONFIG_ENABLED...

Maybe worth raising with the remote config folks what they want to do about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just asked on their Slack channel

end
end
end
Expand Down