Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove delegate_to configuration option from our DSL #3086

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

GustavoCaso
Copy link
Member

@GustavoCaso GustavoCaso commented Aug 29, 2023

What does this PR do?

In our initial discussion, we agreed that the delegate_to option's main functionality was not to cache the result when configuring. For that reason, renaming it to cache would express with more accuracy the intent of the option.

I started by renaming it, but after seeing how much the option code has evolved since the initial conversation with the introduction of precedence, parsing env vars, etc... While trying to rename it to cache I realized that it would be more complicated than it seems, more importantly we have no idea how an option would work using delegate_to in the current system.

For the reason outlined above I think is best to remove the option since no configuration definition is using it, and if we ever want to introduce the ability to configure if an option is cached we could do it in the future, hopefully with some requirements defined.

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@GustavoCaso GustavoCaso requested a review from a team August 29, 2023 11:06
@github-actions github-actions bot added the core Involves Datadog core libraries label Aug 29, 2023
@GustavoCaso GustavoCaso merged commit 30b1703 into master Aug 30, 2023
@GustavoCaso GustavoCaso deleted the core-configuration-remove-delegate_to branch August 30, 2023 08:23
@github-actions github-actions bot added this to the 1.15.0 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants