-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove CI module and add a dependency on datadog-ci gem #3128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
- Coverage 98.17% 98.14% -0.03%
==========================================
Files 1326 1281 -45
Lines 75575 73715 -1860
Branches 3506 3423 -83
==========================================
- Hits 74192 72347 -1845
+ Misses 1383 1368 -15 see 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looking good! 👍 |
Perhaps we should change gemspec to add runtime dependency for ci ? |
@TonyCTHsu didn't I add it to gemspec? I think it is here https://github.com/DataDog/dd-trace-rb/pull/3128/files#diff-8b1801e03e9a166eea28410efc558b347e0b4a3bc03ab6c7283afa4479e88756R72 and all the regenerated gemfiles for appraisals now show datadog-ci (0.1.0) |
babac4a
to
6dd44c6
Compare
cf14e72
to
ec58040
Compare
🕶️ I was blind |
add datadog-ci to the host_inject script
bb4970a
to
430aa03
Compare
What does this PR do?
Phase 1 of the CI migration:
Motivation:
Remove code duplication between gems
Additional Notes:
Not that it is a new runtime dependency I changed
host_inject.rb
script to installdatadog-ci
here:https://github.com/DataDog/dd-trace-rb/pull/3128/files#diff-112f50906c11b7190b1561f372bd7298abe32cda4be0054ced470a584cffb7d3R66
Is there a way to test this? cc @TonyCTHsu
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!