Extract activesupport appraisal group #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
changed the title
TonyCTHsu
force-pushed
the
tonycthsu/extract-activesupport-appraisal-group
branch
from
840cff8 to
5124534
Compare
ekump
approved these changes
Sep 25, 2023
TonyCTHsu
deleted the
tonycthsu/extract-activesupport-appraisal-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
From internal discussion, we want to horizontally scale our appraisal groups, instead of vertically. This means we are breaking large appraisal groups into smaller ones.
What does this PR do?
This group contains a collection of gems that are directly dependent on the activesupport (ie. grape / lograge ) or conduct instrumentation by leveraging ActiveSupport::Notifications (ie. racecar / ruby-kafka ).