Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup appraisal groups #3160

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Cleanup appraisal groups #3160

merged 7 commits into from
Sep 27, 2023

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 27, 2023 •
edited
Loading

Motivation:

Cleanup some obsolete stuff and update appraisals

What does this PR do?

  • Clean up the obsolete comments from the appraisal definition
  • Clean up the obsolete platform check for contrib-old
  • Test the latest 5.x of active record (previously locked due to loofah)
  • Remove explicit rack from contrib groupand updaterack`
  • Add platform to newly created lockfiles

@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Sep 27, 2023
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 27, 2023 08:32
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 27, 2023 08:32
@TonyCTHsu TonyCTHsu merged commit 81f6c12 into master Sep 27, 2023
176 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/tweak-groups branch September 27, 2023 13:14
@github-actions github-actions bot added this to the 1.15.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekump ekump ekump approved these changes

Assignees
No one assigned
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyCTHsu @ekump