Polling the presence of gem to trigger gitlab job #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
dev/ci
Codecov Report
@@ Coverage Diff @@
## master #3161 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 1247 1247
Lines 71703 71703
Branches 3338 3338
==========================================
- Hits 70371 70370 -1
- Misses 1332 1333 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
I think, ideally, this step should be triggered after rubygems.org receives the new gem version.
rubygems.org publishing is not automatic today, so it's not possible to trigger this PR's job after the rubygems.org. But when we automate rubygems.org publishing, we should trigger this PR's job automatically, no through polling.
TonyCTHsu
deleted the
tonycthsu/automate-lib-injection-package-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Building lib injection package depends on the gem ddtrace being published at rubygems.org.
During ddtrace release, the process is triggered by a tag push event from the repository but failed since the gem has not yet been published. It needs to be manually retriggered after the gem is published to rubygems.org successfully.
What does this PR do?
Create a job that makes polling request to rubygems.org and blocks to pipeline until the the gem has been published.