Profiling: Add note about Ruby 3.2 bug #3180
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR adds a reference to https://bugs.ruby-lang.org/issues/19482 / ruby/ruby#7464 to the reasons why `allocation_counting_enabled` should not be enabled on Ruby 3.2.0 to 3.2.2. No code needs to be changed since we were already excluding those Ruby versions due to a different bug. **Motivation:** I like having this in the code as it may be relevant in the future (e.g. if the issue reappears). **Additional Notes:** N/A **How to test the change?** No code is changed!
Codecov Report
@@ Coverage Diff @@
## master #3180 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 1247 1247
Lines 71663 71663
Branches 3329 3329
=======================================
Hits 70381 70381
Misses 1282 1282
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a reference to https://bugs.ruby-lang.org/issues/19482 / ruby/ruby#7464 to the reasons why
allocation_counting_enabledshould not be enabled on Ruby 3.2.0 to 3.2.2.No code needs to be changed since we were already excluding those Ruby versions due to a different bug.
Motivation:
I like having this in the code as it may be relevant in the future (e.g. if the issue reappears).
Additional Notes:
N/A
How to test the change?
No code is changed!
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.