Upgrade steep typechecker to latest version 1.5.3 #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR upgrades the steep typechecker to the latest version available, 1.5.3. It also disables type-checking one of the appsec files that started failing typechecking with this version. **Motivation:** Use latest version of typechecker. **Additional Notes:** N/A **How to test the change?** Observe that typecheck still passes in CI.
Codecov Report
@@ Coverage Diff @@
## master #3198 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 1252 1252
Lines 71937 71937
Branches 3331 3331
=======================================
Hits 70654 70654
Misses 1283 1283 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GustavoCaso
approved these changes
Oct 10, 2023
|
Thanks for fixing the type signatures! I'll admit I was a bit scratching my head on that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades the steep typechecker to the latest version available, 1.5.3.
It also disables type-checking one of the appsec files that started failing typechecking with this version.
Motivation:
Use latest version of typechecker.
Additional Notes:
Here's the full error message for the failing appsec file:The issue with the ASM file has been fix with 7f147ec
How to test the change?
Observe that typecheck still passes in CI.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.