Fix concurrent ruby future propagation without active_trace
#3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloeki
reviewed
Nov 7, 2023
| @@ -135,6 +135,18 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context 'when propagates without an active trace' do | |||
| it 'creates a root span' do | |||
There was a problem hiding this comment.
Fix looks good but that sounds weird. I would expect:
- 'does nothing'
- 'does not raise'
- 'calls executor'
lloeki
reviewed
Nov 7, 2023
|
|
||
| future.wait | ||
|
|
||
| expect(inner_span).to be_root_span |
There was a problem hiding this comment.
I understand that it indirectly test that it did not crash (because if it crashed the test would blow up), but does that actually test that it didn't append a span to the trace?
|
I am merging this to dish out a release as soon as possible. |
TonyCTHsu
deleted the
tonycthsu/fix-concurrent-ruby-future-propagation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Concurrent ruby propagation breaks with
NoMethodErrorwhen there is noactive_traceto propagates.Fix with conditionals.