Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE with 2.0 release notes section #3247

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 7, 2023

This PR ensures that developers are prompted with describing how 2.0 changes will affect users, and how users can migrate their applications successfully to 2.0.

This PR ensures that developers are prompted with describing how 2.0 changes will affect users, and how users can migrate their applications successfully to 2.0.
@marcotc marcotc requested a review from a team as a code owner November 7, 2023 21:58
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Nov 7, 2023
@@ -5,6 +5,17 @@ for guidance on how to set up your development environment,
run the test suite, write new integrations, and more.
-->

**2.0 Upgrade Guide notes**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go towards the bottom under the heading "For Datadog Employees"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should stay on top for visibility.
I think there's a good chance we might miss it if we move it down.

Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of suggestions, but LGTM

marcotc and others added 2 commits November 8, 2023 09:05
Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
@ivoanjo ivoanjo changed the title Update PULL_REQUEST_TEMPLATE with 2.0 relase notes section Update PULL_REQUEST_TEMPLATE with 2.0 release notes section Nov 8, 2023
@marcotc marcotc merged commit df3dc28 into master Nov 10, 2023
177 of 178 checks passed
@marcotc marcotc deleted the 2.0-release-notes-etemplate branch November 10, 2023 20:07
@github-actions github-actions bot added this to the 1.17.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants