-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PULL_REQUEST_TEMPLATE with 2.0 release notes section #3247
Conversation
This PR ensures that developers are prompted with describing how 2.0 changes will affect users, and how users can migrate their applications successfully to 2.0.
@@ -5,6 +5,17 @@ for guidance on how to set up your development environment, | |||
run the test suite, write new integrations, and more. | |||
--> | |||
|
|||
**2.0 Upgrade Guide notes** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go towards the bottom under the heading "For Datadog Employees"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should stay on top for visibility.
I think there's a good chance we might miss it if we move it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of suggestions, but LGTM
Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
Co-authored-by: Edmund Kump <edmund.kump@datadoghq.com>
This PR ensures that developers are prompted with describing how 2.0 changes will affect users, and how users can migrate their applications successfully to 2.0.