Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-8667] Heap Profiling - Part 3 - Snapshot system #3328

Merged
merged 19 commits into from
Dec 21, 2023
+228 −82
Merged

[PROF-8667] Heap Profiling - Part 3 - Snapshot system #3328

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
051c803
[PROF-8667] Heap Profiling - Part 2 - Heap Recorder
AlexJF Nov 23, 2023
774c96a
[PROF-8667] Address first batch of comments
AlexJF Dec 14, 2023
acab787
[PROF-8667] Test to verify matching hash implementations in heap reco…
AlexJF Dec 14, 2023
ed57a26
[PROF-8667] Fix heap recorder hash calculations after line type change
AlexJF Dec 14, 2023
ef2dfbf
[PROF-8667] Heap Profiling - Part 3 - Queue
AlexJF Nov 23, 2023
74ff074
[PROF-8667] Address more comments.
AlexJF Dec 18, 2023
36f556d
[PROF-8667] Lock comment clarification
AlexJF Dec 18, 2023
13bc3e6
Merge branch 'alexjf/prof-8667-heap-profiling-part2-allocations-with-…
AlexJF Dec 18, 2023
14abeb3
[PROF-8667] Rework queue system into a snapshot system.
AlexJF Dec 18, 2023
a7fee6b
[PROF-8667] Disable rubocopy rules locally instead of unused param.
AlexJF Dec 18, 2023
1d14698
[PROF-8667] Fix minor issues with heap tests in stack_recorder
AlexJF Dec 19, 2023
5267f7a
Merge branch 'alexjf/prof-8667-heap-profiling-part2-allocations-with-…
AlexJF Dec 19, 2023
9fd4f13
[PROF-8667] Remove old comment.
AlexJF Dec 19, 2023
5cb7371
Merge branch 'master' into alexjf/prof-8667-heap-profiling-part3-queue
AlexJF Dec 19, 2023
01cb735
Minor cleanups
AlexJF Dec 19, 2023
9dba020
Flakiness debugging
AlexJF Dec 20, 2023
a598746
Try different cleanup strategy
AlexJF Dec 20, 2023
d73978d
Force double GC
AlexJF Dec 20, 2023
d58e2f1
Always debug heap recorder on stack recorder heap test failures
AlexJF Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ext/ddtrace_profiling_native_extension/collectors_stack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
// Gathers stack traces from running threads, storing them in a StackRecorder instance
// This file implements the native bits of the Datadog::Profiling::Collectors::Stack class

#define MAX_FRAMES_LIMIT 10000
#define MAX_FRAMES_LIMIT_AS_STRING "10000"

static VALUE missing_string = Qnil;

// Used as scratch space during sampling
Expand Down
3 changes: 3 additions & 0 deletions ext/ddtrace_profiling_native_extension/collectors_stack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

#include "stack_recorder.h"

#define MAX_FRAMES_LIMIT 10000
#define MAX_FRAMES_LIMIT_AS_STRING "10000"

typedef struct sampling_buffer sampling_buffer;

typedef enum { SAMPLE_REGULAR, SAMPLE_IN_GC } sample_type;
Expand Down
Loading
Loading