Fix OpenTelemetry internal loading #3400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
datadog/opentelemetry
beforeddtrace
,tracing/contrib
files are not loaded.text_map_getter
andrack_env_getter
, but we only supportedtext_map_getter
before. All our propagation code works correctly withrack_env_getter
, so we allow it during configuration.Motivation:
These two issues were found during the setup of https://github.com/DataDog/opentelemetry-demo/pull/42/files#diff-6f62dcc2d3fa2ec6fa2c3529d3d9357ae69c771fca911e87e2e982a45b50fa71
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!