[NO-TICKET] Upgrade to libdatadog 9 #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
force-pushed
the
alexjf/libdatadog9
branch
3 times, most recently
from
97c9a82 to
8f351b6
Compare
marcotc
reviewed
May 8, 2024
datadog.gemspec
Outdated
Comment on lines
15
to
16
| spec.required_ruby_version = [">= #{Datadog::VERSION::MINIMUM_RUBY_VERSION}", "< #{Datadog::VERSION::MAXIMUM_RUBY_VERSION}"] | ||
| spec.required_ruby_version = [">= #{Datadog::VERSION::MINIMUM_RUBY_VERSION}", | ||
| "< #{Datadog::VERSION::MAXIMUM_RUBY_VERSION}"] |
There was a problem hiding this comment.
I believe this breaks a sed script in one of our workflows, meaning we should keep this in one line.
Did Robocop change this automatically for you?
There was a problem hiding this comment.
It does indeed look like an auto-fix. I'll restore this and add a rubocop exception, to avoid it happening accidentally again.
ivoanjo
force-pushed
the
alexjf/libdatadog9
branch
from
8f351b6 to
3c27b38
Compare
|
Thanks @AlexJF for starting off this work! I'm taking over from here as Alex is busy with very important things ™️ 😉 I've tweaked the change to the gemspec and validated that I locally get a green test-run. I'll work to get libdatadog 9 published on rubygems.org, and will mark this PR as non-draft once everything is good to go :) |
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
May 9, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the v7.0.0 release PR). It also includes a tiny paper cut fix: it disables the Rake `build` task which is the default way to package a Ruby gem, since we have our own custom packaging steps in the `Rakefile`. **Motivation:** Enable Ruby to use libdatadog v9.0.0. **Additional Notes:** We ended up not packaging the previous release (v8) for Ruby, so we're directly jumping from v7 to v9. **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3627 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
May 9, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the v7.0.0 release PR). It also includes a tiny paper cut fix: it disables the Rake `build` task which is the default way to package a Ruby gem, since we have our own custom packaging steps in the `Rakefile`. **Motivation:** Enable Ruby to use libdatadog v9.0.0. **Additional Notes:** We ended up not packaging the previous release (v8) for Ruby, so we're directly jumping from v7 to v9. **How to test the change?** I've tested this release locally using the changes in DataDog/dd-trace-rb#3627 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
This was referenced May 9, 2024
ivoanjo
force-pushed
the
alexjf/libdatadog9
branch
from
3c27b38 to
3a6b242
Compare
|
Libdatadog 9 is now on rubygems.org, and CI is almost green (with some unrelated flakes -- I'll retry those) so this is ready to review :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3627 +/- ##
==========================================
- Coverage 98.13% 98.13% -0.01%
==========================================
Files 1223 1223
Lines 72139 72139
Branches 3421 3421
==========================================
- Hits 70795 70794 -1
- Misses 1344 1345 +1 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
approved these changes
May 10, 2024
lloeki
approved these changes
May 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades dd-trace-rb to use libdatadog 9.
Even though there were a few breaking API changes, none of those APIs were being used in the Ruby profiler, so it's a very minor bump for us.
Motivation:
This version includes a number of fixes and tweaks that will finally enable us to land the crash tracker feature (#3384).
How to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)