-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDTEST-409] Telemetry metrics data model #3734
Conversation
329b91a
to
5d4046c
Compare
24a0409
to
5729921
Compare
0e68f8a
to
9554754
Compare
9554754
to
a7974f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3734 +/- ##
========================================
Coverage 98.10% 98.11%
========================================
Files 1227 1229 +2
Lines 73014 73246 +232
Branches 3508 3515 +7
========================================
+ Hits 71633 71864 +231
- Misses 1381 1382 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the diff and I have no objections, though I am not familiar with the product enough to leave a checkmark at this time.
What does this PR do?
This PR is a first step towards full metrics support for internal Datadog telemetry.
It handles data model for the future metrics implementation:
generate-metrics
anddistributions
events to telemetryThis PR does not handle (subject for subsequent PRs):
Motivation:
Add telemetry metrics support in bite-sized and digestible fashion.
Additional Notes:
Pay attention to
#track
method in each of the metrics implementations: this is the aggregations logic that is different for every metric type.How to test the change?
Only unit tests currently.