Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM/DBM peer entity tags #3789

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add ARM/DBM peer entity tags #3789

merged 1 commit into from
Jul 17, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jul 16, 2024

Populate additional DBM SQL comment propagation values to provide enough information to enable Inferred Service dependencies for databases.

Additional Notes:
See internal Slack for further documentation for this implementation.

How to test the change?
All changes are covered by tests.

Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
@marcotc marcotc requested review from a team as code owners July 16, 2024 23:30
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jul 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (f867bd9) to head (0336db2).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3789   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files        1246     1246           
  Lines       74999    75029   +30     
  Branches     3627     3629    +2     
=======================================
+ Hits        73435    73466   +31     
+ Misses       1564     1563    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the types as well!

@marcotc marcotc merged commit 0294ceb into master Jul 17, 2024
170 checks passed
@marcotc marcotc deleted the dbm-tags branch July 17, 2024 20:03
@github-actions github-actions bot added this to the 2.3.0 milestone Jul 17, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants