Add directives support for graphql appsec #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
marcotc
approved these changes
Jul 29, 2024
marcotc
merged commit be222c5
into
vpellan/graphql-unified-tracer-require
172 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This add support for directive on GraphQL Threats protection
Motivation:
This was missed during development and found using system-tests
Additional Notes:
This also reorganize the integration tests a bit, and add a custom directive to the test schema.
How to test the change?
This includes integration tests accordingly. This can also be tests using this branch of system-tests :
https://github.com/DataDog/system-tests/tree/vpellan/ruby-graphql-threats
Unsure? Have a question? Request a review!