-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit log message for incompatible Lograge setup #3839
Conversation
BenchmarksBenchmark execution time: 2024-08-12 23:14:11 Comparing candidate commit 482b48a in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - Allocations ()
scenario:profiler - sample timeline=false
|
83c0965
to
d7e71dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 1264 1264
Lines 75682 75696 +14
Branches 3720 3723 +3
==========================================
+ Hits 74053 74061 +8
- Misses 1629 1635 +6 ☔ View full report in Codecov by Sentry. |
We've started getting this error message since this update. However, we already account for this with customisations to the log formatter to output in JSON and include Datadog tags: Can we add a way to disable this warning to stop polluting our startup logs? |
Hey @marcotc just wanted to +1 for a way to disable this warning message. I'm also confused about the exact behavior that's broken. We set up some log remapping that ensures the datadog trace IDs are properly read as trace IDs and we still have log correlation working. Is there anything else that might be missing with Thank you! |
Closes #2012
This PR emits an error-level log message when the
lograge
gem is used with Rails tagged logging, which is configured by default in Rails since Rails 5.We can't practically fix the issue here in
dd-trace-rb
, since the issue is a log formatting conflict betweenlograge
andRails
.The reason this affects APM Tracing is because it breaks trace-log correlation.
The only alternatives are to either: disable Rails tagged logging; or not use
lograge
.The investigation and suggest alternatives are well documented here: #2012 (comment)