-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make user_id optional for track_login_failure #3841
Conversation
Fixes #3840. `Datadog::Kit::AppSec::Events.track_login_failure` should not raise when `user_id` is not provided and `user_exists` flag set to false.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3841 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1264 1264
Lines 75678 75682 +4
Branches 3720 3720
=======================================
+ Hits 74039 74045 +6
+ Misses 1639 1637 -2 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-08-12 15:09:08 Comparing candidate commit 44834a4 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics. scenario:hold / resume
|
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
/merge -c |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
Fixes #3840.
What does this PR do?
This PR fixes a bug when
Datadog::Kit::AppSec::Events.track_login_failure
is raising anArgumentError
whenuser_id
is not provided anduser_exists
flag is set to false.Motivation:
Issue #3840