[NO-TICKET] Tweak duration of profiler_sample_serialize benchmark #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR tweaks the default duration of the `benchmarks/profiler_sample_serialize.rb` benchmark. This duration gets used when we run benchmarks on every PR. **Motivation:** We've been seeing quite a bit of variance in the benchmarks from run-to-run which makes it seem like there are regressions/improvements even when nothing of consequence is touched (e.g. PR that changes docs even). This got better when we adjusted the thresholds used by the benchmarking platform, but I'm still seeing this benchmark in particular show up quite often in a "flaky" way. I suspect this behavior may be because each step on this benchmark takes more than one second (since it simulates 60 seconds of profiling data) and thus the low number of iterations creates more noise. I'm hoping that by raising the duration of this benchmark to 1 minute we'll see the run-to-run variation go down. **Additional Notes:** N/A **How to test the change?** Validate benchmark is running for 1 minute in CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3928 +/- ##
=======================================
Coverage 97.78% 97.79%
=======================================
Files 1291 1291
Lines 77149 77149
Branches 3810 3810
=======================================
+ Hits 75440 75447 +7
+ Misses 1709 1702 -7 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-09-19 05:40:22 Comparing candidate commit 3b54135 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
y9v
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the default duration of the
benchmarks/profiler_sample_serialize.rbbenchmark. This duration gets used when we run benchmarks on every PR.Motivation:
We've been seeing quite a bit of variance in the benchmarks from run-to-run which makes it seem like there are regressions/improvements even when nothing of consequence is touched (e.g. PR that changes docs even).
This got better when we adjusted the thresholds used by the benchmarking platform, but I'm still seeing this benchmark in particular show up quite often in a "flaky" way.
I suspect this behavior may be because each step on this benchmark can take
takesmore than one second (since it simulates 60 seconds of profiling data) and thus the low number of iterations creates more noise.I'm hoping that by raising the duration of this benchmark to 1 minute we'll see the run-to-run variation go down.
Additional Notes:
N/A
How to test the change?
Validate benchmark is running for 1 minute in CI.